[webkit-reviews] review requested: [Bug 116686] [Soup] [Gstreamer] ASSERT in StreamingClient::getOrCreateReadBuffer : [Attachment 203367] Patch

[bugzilla-daemon at webkit.org]

Alberto Garcia <agarcia at igalia.com> has asked  for review:
Bug 116686: [Soup] [Gstreamer] ASSERT in StreamingClient::getOrCreateReadBuffer
https://bugs.webkit.org/show_bug.cgi?id=116686

Attachment 203367: Patch
https://bugs.webkit.org/attachment.cgi?id=203367&action=review

------- Additional Comments from Alberto Garcia <agarcia at igalia.com>
(In reply to comment #3)
> Memory is not leaking because buffer is a GRefPtr.

Yes, you're right.

This patch removes the assertion and returns the buffer if it
exists. I don't see any other crash or assertion being triggered and
everytime a new buffer is created it seems to be cleared correctly
afterwards.

Then we have the thing that the requestedSize parameter is completely
ignored if the buffer already exists, although in practice this is not
happening since we're using a constant value that is defined in
ResourceHandle::ensureReadBuffer()