[webkit-reviews] review denied: [Bug 116814] Webkit crashes while loading content from Application Cache : [Attachment 203188] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 116814: Webkit crashes while loading  content from Application Cache
https://bugs.webkit.org/show_bug.cgi?id=116814

Attachment 203188: Patch
https://bugs.webkit.org/attachment.cgi?id=203188&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203188&action=review


>
LayoutTests/http/tests/appcache/main-resource-fallback-for-network-error-crash.
html:13
> +function setNetworkEnabled(state)

This function is never called. I don't think that the test verifies that the
bug is fixed when running in an automated manner.

Please verify tests by removing the associated code changes, and confirming
that they actually fail without those.

>
LayoutTests/http/tests/appcache/main-resource-fallback-for-network-error-crash.
html:34
> +    if (window.testRunner)
> +    {
> +	   var evt = document.createEvent("MouseEvents");
> +	   evt.initMouseEvent("click");
> +	   var link = document.getElementById("Link");
> +	   link.dispatchEvent(evt);
> +	   return;
> +    } 

There is no need to simulate a click to navigate, you can just do

window.location = "resources/does-not-exist";