[webkit-reviews] review granted: [Bug 116870] Allow no space between "background-position:" dimensions : [Attachment 203353] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 116870: Allow no space between "background-position:" dimensions
https://bugs.webkit.org/show_bug.cgi?id=116870

Attachment 203353: Patch
https://bugs.webkit.org/attachment.cgi?id=203353&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203353&action=review


Looks OK to me. Hope we have sufficient test coverage. I’d like this better if
it came with more new tests.

> Source/WebCore/css/CSSGrammar.y.in:1817
> -    '(' maybe_space calc_func_expr maybe_space ')' maybe_space {
> +    '(' maybe_space calc_func_expr calc_closing_paren {

Seems overkill to have a separate token just for optional space followed by
parenthesis; maybe there is some good reason for it, though.