[webkit-reviews] review granted: [Bug 117019] Avoid using CSSOM style declarations in HTML editing. : [Attachment 203330] Pretentious patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 30 03:33:00 PDT 2013


Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 117019: Avoid using CSSOM style declarations in HTML editing.
https://bugs.webkit.org/show_bug.cgi?id=117019

Attachment 203330: Pretentious patch
https://bugs.webkit.org/attachment.cgi?id=203330&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=203330&action=review


> Source/WebCore/ChangeLog:60
> +	   (WebCore::getPropertyValue):
> +	   (WebCore::getIdentifierValue):
> +	   (WebCore::getRGBAFontColor):
> +	   (WebCore::getRGBABackgroundColor):

Would be nice to use webkit naming style here (get* is only used for functions
that return value in argument).

> Source/WebCore/ChangeLog:70
> +	   (WebCore::getPropertiesNotIn):

Here too.


More information about the webkit-reviews mailing list