[webkit-reviews] review requested: [Bug 116935] WebSQL forces 16-bit strings : [Attachment 203305] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has asked  for review:
Bug 116935: WebSQL forces 16-bit strings
https://bugs.webkit.org/show_bug.cgi?id=116935

Attachment 203305: Patch
https://bugs.webkit.org/attachment.cgi?id=203305&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203305&action=review


I’d love to see an optimized path for the common case where no characters need
escaping. It also seems a little strange to put the 8/16 bit case inside the
loop.

> Source/WebCore/platform/FileSystem.cpp:84
> +    const StringImpl* stringImpl = inputString.impl();

No reason for const StringImpl, since StringImpl is an immutable class. You
should take out the const.