[webkit-reviews] review denied: [Bug 116849] It is too easy to accidentally construct a Color : [Attachment 203215] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Sam Weinig <sam at webkit.org>'s request
for review:
Bug 116849: It is too easy to accidentally construct a Color
https://bugs.webkit.org/show_bug.cgi?id=116849

Attachment 203215: Patch
https://bugs.webkit.org/attachment.cgi?id=203215&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203215&action=review


I can’t tell what you intend, Sam. Besides adoption of fooColor functions, this
patch contains many examples of adding explicit Color() casts. Did you mean to
include them or save them for a separate patch?

> Source/WebCore/WebCore.exp.in:1
> +__ZN7WebCore14SecurityOrigin16setDomainFromDOMERKN3WTF6StringE

Oops.

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:99
> +		7C54FC711754712F00A8B391 /* SecurityOriginHash.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = 7C54FC6F17546D3000A8B391 /*
SecurityOriginHash.cpp */; };

Oops.

> Tools/TestWebKitAPI/Tests/WebCore/SecurityOriginHash.cpp:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

Oops.