[webkit-reviews] review granted: [Bug 116984] Return earlier if there's no session storage namespace : [Attachment 203257] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 29 12:42:02 PDT 2013


Tim Horton <timothy_horton at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 116984: Return earlier if there's no session storage namespace
https://bugs.webkit.org/show_bug.cgi?id=116984

Attachment 203257: Patch
https://bugs.webkit.org/attachment.cgi?id=203257&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203257&action=review


Seems ok.

>> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:465
>> +	ASSERT((HashMap<uint64_t,
RefPtr<SessionStorageNamespace>>::isValidKey(storageNamespaceID)));
> 
> Missing spaces around >>  [whitespace/operators] [3]

We should file a bug about the stylebot.


More information about the webkit-reviews mailing list