[webkit-reviews] review granted: [Bug 113221] prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):" : [Attachment 203212] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Ruth Fong <ruthiecftg at gmail.com>'s
request for review:
Bug 113221: prepare-Changelog should not be generating namespace-only or
class-name-only lines like "(WebCore):"
https://bugs.webkit.org/show_bug.cgi?id=113221

Attachment 203212: Patch
https://bugs.webkit.org/attachment.cgi?id=203212&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203212&action=review


> Tools/ChangeLog:13
> +	   Reviewed by NOBODY (OOPS!).
> +

Reviewed by line should appear above the long description but below the bug url
separated both by a single blank line as done here.

> Tools/Scripts/prepare-ChangeLog:948
> +sub does_namespaces_contain_function(\@$)

This function should probably be named either "do_namespaces_contain_function"
or "is_function_in_namespaces".