[webkit-reviews] review denied: [Bug 116858] Bad value in tests counter at new-run-webkit-tests in --debug-rwt-logging mode : [Attachment 203146] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 29 12:21:15 PDT 2013
Dirk Pranke <dpranke at chromium.org> has denied Dariusz Frankiewicz
<d.frankiewic at samsung.com>'s request for review:
Bug 116858: Bad value in tests counter at new-run-webkit-tests in
--debug-rwt-logging mode
https://bugs.webkit.org/show_bug.cgi?id=116858
Attachment 203146: Patch
https://bugs.webkit.org/attachment.cgi?id=203146&action=review
------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
if you incremented 'num_completed' before the test has completed, that's wrong,
isn't it? :) At the very least, you should change the name to 'num_started',
and make sure you update the other places it is used.
More information about the webkit-reviews
mailing list