[webkit-reviews] review granted: [Bug 116965] Move computed style extraction out of CSSComputedStyleDeclaration. : [Attachment 203202] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 116965: Move computed style extraction out of CSSComputedStyleDeclaration.
https://bugs.webkit.org/show_bug.cgi?id=116965

Attachment 203202: Patch
https://bugs.webkit.org/attachment.cgi?id=203202&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=203202&action=review


r=me

> Source/WebCore/css/CSSComputedStyleDeclaration.h:78
> +    PassRefPtr<CSSValueList>
getCSSPropertyValuesForShorthandProperties(const StylePropertyShorthand&)
const;
> +    PassRefPtr<CSSValueList> getCSSPropertyValuesForSidesShorthand(const
StylePropertyShorthand&) const;
> +    PassRefPtr<CSSValueList> getBackgroundShorthandValue() const;
> +    PassRefPtr<CSSValueList> getCSSPropertyValuesForGridShorthand(const
StylePropertyShorthand&) const;

At some point we should fix the naming to follow WebKit style.

> Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:63
> -PassRefPtr<SVGPaint>
CSSComputedStyleDeclaration::adjustSVGPaintForCurrentColor(PassRefPtr<SVGPaint>
newPaint, RenderStyle* style) const
> +PassRefPtr<SVGPaint>
ComputedStyleExtractor::adjustSVGPaintForCurrentColor(PassRefPtr<SVGPaint>
newPaint, RenderStyle* style) const

Annoying how this is spread out to multiple files.