[webkit-reviews] review granted: [Bug 84525] Improve performance of removing user and password from URLs : [Attachment 203122] Improve performance of removing user and password from URLs By making the new remove function.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 28 23:10:25 PDT 2013


Meeyoung Kim <meeyoung.kim at lge.com> has granted  review:
Bug 84525: Improve performance of removing user and password from URLs
https://bugs.webkit.org/show_bug.cgi?id=84525

Attachment 203122: Improve performance of removing user and password from URLs
By making the new remove function.
https://bugs.webkit.org/attachment.cgi?id=203122&action=review

------- Additional Comments from Meeyoung Kim <meeyoung.kim at lge.com>
"Committed r114843" has a bug when it is called from strippedForUseAsReferrer()
and removeCredentials().

In thease case, the aim of setUser() and setPass() is that removing the user
and passward from m_string.

But the user is not removed from m_string in this commited r114843. Because
user is empty.

So, Improve performance of removing user and password from URLs By making the
new remove function.


More information about the webkit-reviews mailing list