[webkit-reviews] review granted: [Bug 116900] Animations do not restart after exiting page cache : [Attachment 203115] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 116900: Animations do not restart after exiting page cache
https://bugs.webkit.org/show_bug.cgi?id=116900

Attachment 203115: Patch
https://bugs.webkit.org/attachment.cgi?id=203115&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203115&action=review


> Source/WebCore/ChangeLog:11
> +	   was an error in r149576 which was checking a global suspended
> +	   on the AnimationController and not trying to resume anything

a global suspended *what*.

> Source/WebCore/page/animation/AnimationController.cpp:-315
> -    if (!isSuspended())
> -	   return;

How sure are we that there are no cases where this will accidentally get called
twice/is there any potential downside to that?