[webkit-reviews] review denied: [Bug 113221] prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):" : [Attachment 202632] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 28 16:44:14 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has denied Ruth Fong <ruthiecftg at gmail.com>'s
request for review:
Bug 113221: prepare-Changelog should not be generating namespace-only or
class-name-only lines like "(WebCore):"
https://bugs.webkit.org/show_bug.cgi?id=113221

Attachment 202632: Patch
https://bugs.webkit.org/attachment.cgi?id=202632&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202632&action=review


> Tools/ChangeLog:8
> +	   * Scripts/prepare-ChangeLog:

We have tests for this script in
Tools/Scritps/webkitperl/prepare-ChangeLog_unittest.
Did you run test-webkitperl to see if they still pass or not?
We should be adding some tests at least. r- due to the lack of tests.


More information about the webkit-reviews mailing list