[webkit-reviews] review granted: [Bug 116698] [Windows] NRWT reports failure for 'mac' test cases : [Attachment 203102] Uses dpranke's suggested syntax for excluding the mac test folders.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 28 15:57:12 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 116698: [Windows] NRWT reports failure for 'mac' test cases
https://bugs.webkit.org/show_bug.cgi?id=116698

Attachment 203102: Uses dpranke's suggested syntax for excluding the mac test
folders.
https://bugs.webkit.org/attachment.cgi?id=203102&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203102&action=review


> Tools/Scripts/webkitpy/port/win.py:123
> +	   # Remove the mac tests, which we never want to execute

This comment more or less repeats the code. Please remove it.


More information about the webkit-reviews mailing list