[webkit-reviews] review denied: [Bug 116698] [Windows] NRWT reports failure for 'mac' test cases : [Attachment 203094] Cleaned up to reduce code duplication.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 28 14:59:05 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 116698: [Windows] NRWT reports failure for 'mac' test cases
https://bugs.webkit.org/show_bug.cgi?id=116698

Attachment 203094: Cleaned up to reduce code duplication.
https://bugs.webkit.org/attachment.cgi?id=203094&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203094&action=review


> Tools/Scripts/webkitpy/port/win.py:124
> +	   # Remove the mac tests, which we never want to execute
> +	   regex = re.compile('mac.*')

We don't need to use a regex for this. Also, this regex is going to match
anything that happens to start with "mac"; e.g. maclaine.

> Tools/Scripts/webkitpy/port/win.py:125
> +	   test_fallback_names = [x for x in self.baseline_search_path() if not
regex.match(x)]

Please don't use one letter variable like x. spell out path. We can do
path.startswith('mac/') instead.


More information about the webkit-reviews mailing list