[webkit-reviews] review granted: [Bug 75707] [Windows] Many css2.1 tests fail on Apple's Windows port under NRWT : [Attachment 203088] Updated to include export definition changes needed for clean build.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 75707: [Windows] Many css2.1 tests fail on Apple's Windows port under NRWT
https://bugs.webkit.org/show_bug.cgi?id=75707

Attachment 203088: Updated to include export definition changes needed for
clean build.
https://bugs.webkit.org/attachment.cgi?id=203088&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203088&action=review


I’d like to see these patches make less use of internal WebCore data structures
and functions.

> Source/WebKit/ChangeLog:9
> +	   * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
> +	   Export the WebCore::directoryName method for use by DRT.

I don’t think this is a step in the right direction. Ideally DumpRenderTree is
“outside WebKit” code, and we should not be exporting more functions for it to
use. Especially functions that are just file system helpers that have no
special WebKit magic in them.