[webkit-reviews] review denied: [Bug 115613] GraphicsLayers should be aware of rounded rect clipping : [Attachment 201069] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 28 14:13:24 PDT 2013
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Noam Rosenthal
<noam at webkit.org>'s request for review:
Bug 115613: GraphicsLayers should be aware of rounded rect clipping
https://bugs.webkit.org/show_bug.cgi?id=115613
Attachment 201069: Patch
https://bugs.webkit.org/attachment.cgi?id=201069&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201069&action=review
> Source/WebCore/rendering/RenderLayerBacking.cpp:730
> + RoundedRect roundedRect = roundedRectMask(renderer());
> + m_graphicsLayer->setRoundedRectMask(roundedRect);
This seems wrong. For a rounded-corner layer with box-shadow or an overflowing
child, it will clip the shadow/child.
More information about the webkit-reviews
mailing list