[webkit-reviews] review denied: [Bug 113742] Tests added in r141354 erroneously assumes correction suggestion to be in the context menu : [Attachment 202670] compare quantity of context menu elements

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 113742: Tests added in r141354 erroneously assumes correction suggestion to
be in the context menu
https://bugs.webkit.org/show_bug.cgi?id=113742

Attachment 202670: compare quantity of context menu elements
https://bugs.webkit.org/attachment.cgi?id=202670&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202670&action=review


> LayoutTests/editing/spelling/spelling-multiword-selection.html:30
> +    // Context click on 'wellcome' to get its spell check suggestions.
> +    var x = destination.offsetParent.offsetLeft + destination.offsetLeft +
40;
> +    var y = destination.offsetParent.offsetTop + destination.offsetTop +
destination.offsetHeight / 2;
> +    eventSender.mouseMoveTo(x, y);
> +    contextMenuElementsWithSpellingSuggestions = eventSender.contextClick();

> +    // Esc key to hide the context menu.
> +    eventSender.keyDown(String.fromCharCode(0x001B), null);
> +

We shouldn't be checking the items inside a context menu. The fact some ports
populate context menu with spelling suggestions doesn't mean all ports do.