[webkit-reviews] review requested: [Bug 116096] DOMFileSystemBase: merge BlackBerry implementation : [Attachment 203068] Patch

[bugzilla-daemon at webkit.org]

Alberto Garcia <agarcia at igalia.com> has asked  for review:
Bug 116096: DOMFileSystemBase: merge BlackBerry implementation
https://bugs.webkit.org/show_bug.cgi?id=116096

Attachment 203068: Patch
https://bugs.webkit.org/attachment.cgi?id=203068&action=review

------- Additional Comments from Alberto Garcia <agarcia at igalia.com>
(In reply to comment #8)
> The path.isEmpty() check here is redundant. Please remove it. I
> think I made this same comment on an earlier version of this patch.

You're right, sorry!

I've just uploaded a new patch addressing all the other issues that
you mentioned.

temporaryPathPrefix and friends are public constants exported from the
header file, so we cannot really change them.

For this new patch I used String::substringSharingImpl(), which is
more efficient and allows us to use startsWith() to check the prefix.