[webkit-reviews] review granted: [Bug 115880] [GTK] Connection issues in repeated WebProcess crash/reloads. : [Attachment 203037] Updated patch including ChangeLog entry

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 115880: [GTK] Connection issues in repeated WebProcess crash/reloads.
https://bugs.webkit.org/show_bug.cgi?id=115880

Attachment 203037: Updated patch including ChangeLog entry
https://bugs.webkit.org/attachment.cgi?id=203037&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203037&action=review


>> Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp:140
>> +#endif
> 
> Ideally everyone would close the socket in the same way. I think we should
put a TODO here for other ports and open bugs.

I agree, having the work queue take ownership of the file descriptor is
necessary to avoid race conditions.