[webkit-reviews] review granted: [Bug 113703] [CSS Regions] Content that has overflow: scroll cannot be scrolled by dragging the scroll thumbs with the mouse : [Attachment 203055] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mihai Maerean <mmaerean at adobe.com>'s
request for review:
Bug 113703: [CSS Regions] Content that has overflow: scroll cannot be scrolled
by dragging the scroll thumbs with the mouse
https://bugs.webkit.org/show_bug.cgi?id=113703

Attachment 203055: patch
https://bugs.webkit.org/attachment.cgi?id=203055&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203055&action=review


r=me, but please fix the style issue

> Source/WebCore/rendering/RenderBoxModelObject.cpp:2859
> +	   RenderRegion* startRegion, *endRegion;

We never declare multiple variables on a single line like this. It’s
particularly confusing style to do it with pointers, since we typically put the
"*" by the type and ignore the fact that C syntax doesn’t work that way. This
line of code forces the issue. Just use two separate definitions on two
separate lines to do away with that potential confusion.