[webkit-reviews] review denied: [Bug 116849] It is too easy to accidentally construct a Color : [Attachment 203019] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 28 08:58:59 PDT 2013


Darin Adler <darin at apple.com> has denied Sam Weinig <sam at webkit.org>'s request
for review:
Bug 116849: It is too easy to accidentally construct a Color
https://bugs.webkit.org/show_bug.cgi?id=116849

Attachment 203019: Patch
https://bugs.webkit.org/attachment.cgi?id=203019&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I suggest doing this in a couple steps. I’d add the transparentColor(),
whiteColor(), blackColor(), and other three functions first and adopt them
without the rest of the change, since that seems to be more than half of the
patch.

If you want to do this the way I did AdoptCF, then you should have the thing
set up locally with explicit constructors, but not land that part until you
separately land all the adoption. Then you can have a patch that just tries to
flip the switch.

RenderTheme::platformTapHighlightColor seems to be the reason for the EFL and
Qt failures. prepareCairoContextSource the reason for the GTK failure. There
are Windows failures. And probably iOS ones too.

I’m going to say review-, but I did not spot any problems with the patch other
than the fact that it fails to compile on all the non-Mac platforms.


More information about the webkit-reviews mailing list