[webkit-reviews] review denied: [Bug 116714] [WK2][GTK] Use GtkWindow::is-active to set WindowIsActive flag in WebViewBase : [Attachment 203010] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 116714: [WK2][GTK] Use GtkWindow::is-active to set WindowIsActive flag in
WebViewBase
https://bugs.webkit.org/show_bug.cgi?id=116714

Attachment 203010: Patch
https://bugs.webkit.org/attachment.cgi?id=203010&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203010&action=review


I wonder if we still need the hack when the toplevel is a popup and the focus
has been set programatically by WTR. Did you run the tests?

> Source/WebKit2/ChangeLog:7
> +

You should explain here the changes, why are they needed? what bug does this
fix exactly? What's the new behaviour? what's broken before? etc.

> Source/WebKit2/ChangeLog:12
> +	   GtkWindow::is-toplevel instead of focus-in/out to set the

is-toplevel? I guess you mean is-active

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:116
> +    unsigned long toplevelIsActiveID;

Nit: I would use toplevelNotifyIsActiveID to make a bit clearer this is the ID
of a signal handler.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:167
> +static void toplevelWindowNotifyIsActive(GtkWindow* window, GParamSpec*
pspec, WebKitWebViewBase* webViewBase)

Remove the names of unused parameters (pspec).

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:170
> +    priv->isInWindowActive = gtk_window_is_active(window);

Do we still need to cache the value? or can we use gtk_window_is_active(window)
directly when needed?