[webkit-reviews] review denied: [Bug 116821] isDisabledFormControl() should apply for shadow dom element also : [Attachment 202971] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Santosh Mahto
<santosh.ma at samsung.com>'s request for review:
Bug 116821: isDisabledFormControl() should apply for shadow dom element also
https://bugs.webkit.org/show_bug.cgi?id=116821

Attachment 202971: Patch
https://bugs.webkit.org/attachment.cgi?id=202971&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202971&action=review


Your patch needs a test, a description in the ChangeLog.
It looks like it also broke some tests. Make sure you run the tests before
submitting something.

> Source/WebCore/dom/Element.cpp:1142
> +    Element* host = shadowHost();
> +    if (host)
> +	   return host->isDisabledFormControl();

Following WebKit's style, this would be: 
if (Element* host = shadowHost())
    return host->isDisabledFormControl();