[webkit-reviews] review denied: [Bug 116814] Webkit crashes while loading content from Application Cache : [Attachment 202960] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 27 20:35:22 PDT 2013
Sam Weinig <sam at webkit.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 116814: Webkit crashes while loading content from Application Cache
https://bugs.webkit.org/show_bug.cgi?id=116814
Attachment 202960: Patch
https://bugs.webkit.org/attachment.cgi?id=202960&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202960&action=review
> Source/WebCore/ChangeLog:8
> + Webkit crashes while loading content from Application Cache
> + https://bugs.webkit.org/show_bug.cgi?id=116814
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + No new tests, refactor appcache loading.
This doesn't make sense. If this is fixing a crash, it is not just
refactoring. And if is a crash fix, it should have a test case.
More information about the webkit-reviews
mailing list