[webkit-reviews] review canceled: [Bug 116842] Move hasNonEmptyBoundingBox from Node to RenderBoxModelObject : [Attachment 203008] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 27 16:20:13 PDT 2013
Darin Adler <darin at apple.com> has canceled Darin Adler <darin at apple.com>'s
request for review:
Bug 116842: Move hasNonEmptyBoundingBox from Node to RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=116842
Attachment 203008: Patch
https://bugs.webkit.org/attachment.cgi?id=203008&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203008&action=review
>> Source/WebCore/html/HTMLAnchorElement.cpp:125
>> + return renderer && renderer->hasNonEmptyBox();
>
> Unless this is going to have other clients I would just put it to
HTMLAnchorElement. No need to bloat RenderBoxModelObject with questionable
special case functions like this (any more than Node).
OK.
More information about the webkit-reviews
mailing list