[webkit-reviews] review granted: [Bug 116844] Deleting static properties defined with the JSC API should work : [Attachment 203013] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 116844: Deleting static properties defined with the JSC API should work
https://bugs.webkit.org/show_bug.cgi?id=116844

Attachment 203013: Patch
https://bugs.webkit.org/attachment.cgi?id=203013&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203013&action=review


> Source/JavaScriptCore/ChangeLog:21
> +	   (JSC::::getOwnPropertySlot):

The script screws up parsing these function names. You should put in the
JSCallbackObject part by hand if you are leaving these lines in.

> Source/JavaScriptCore/API/JSCallbackObject.h:82
> +	   if (!m_deletedStaticProperties)
> +	       return false;
> +	   return m_deletedStaticProperties->contains(name);

I like to write these with && instead of an early return.