[webkit-reviews] review granted: [Bug 116829] [CSS] -webkit-var prefix is case-sensitive : [Attachment 203003] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 116829: [CSS] -webkit-var prefix is case-sensitive
https://bugs.webkit.org/show_bug.cgi?id=116829

Attachment 203003: Patch
https://bugs.webkit.org/attachment.cgi?id=203003&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203003&action=review


> Source/WebCore/css/CSSParser.cpp:9867
> +	   ASSERT((*constantString >= 'a' && *constantString <= 'z') ||
*constantString == '-');

There is no reason to have this assertion. I know the previous reviewer
suggested you add it. But the assertion above is there because it’s a
precondition to calling toASCIILowerUnchecked. There’s no corresponding issue
here and no need for the assertion.