[webkit-reviews] review granted: [Bug 116818] Tighten FontGlyphs interfaces to take FontDescription instead of Font : [Attachment 202963] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 116818: Tighten FontGlyphs interfaces to take FontDescription instead of
Font
https://bugs.webkit.org/show_bug.cgi?id=116818

Attachment 202963: patch
https://bugs.webkit.org/attachment.cgi?id=202963&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202963&action=review


> Source/WebCore/ChangeLog:8
> +	   This gives better understanding of what the actual inputs are.

I like this change a lot.

> Source/WebCore/platform/graphics/FontFallbackList.h:107
> -    mutable unsigned m_pitch : 3; // Pitch
> +    mutable unsigned m_pitch : 3;

I think the "Pitch" here is to signify that the type of m_pitch is actually
Pitch (the enum.)
Still pretty redundant, though.