[webkit-reviews] review granted: [Bug 116803] Encapsulate FontGlyphs : [Attachment 202942] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 26 18:38:12 PDT 2013


Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 116803: Encapsulate FontGlyphs
https://bugs.webkit.org/show_bug.cgi?id=116803

Attachment 202942: patch
https://bugs.webkit.org/attachment.cgi?id=202942&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202942&action=review


r=me

> Source/WebCore/ChangeLog:21
> +	       Helpers form FontFastPath.cpp.

Typo, from.

> Source/WebCore/platform/graphics/FontFallbackList.cpp:62
> +    m_realizedFontData.append(fontData);

You should .release() the RefPtr here. Or make it a one-liner.


More information about the webkit-reviews mailing list