[webkit-reviews] review granted: [Bug 116785] Move "active" state logic from Node to Element. : [Attachment 202919] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 26 07:10:02 PDT 2013


Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 116785: Move "active" state logic from Node to Element.
https://bugs.webkit.org/show_bug.cgi?id=116785

Attachment 202919: Patch
https://bugs.webkit.org/attachment.cgi?id=202919&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=202919&action=review


> Source/WebCore/dom/Element.cpp:517
> +	   // FIXME: Find a substitute for usleep for Win32.

You should remove this.

> Source/WebCore/dom/Element.cpp:518
> +	   // Better yet, come up with a way of doing this that doesn't use
this sort of thing at all.

And make this the FIXME.


More information about the webkit-reviews mailing list