[webkit-reviews] review granted: [Bug 116744] Animated GIFs don't repaint after TCADA un-suspends painting : [Attachment 202861] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 116744: Animated GIFs don't repaint after TCADA un-suspends painting
https://bugs.webkit.org/show_bug.cgi?id=116744

Attachment 202861: patch
https://bugs.webkit.org/attachment.cgi?id=202861&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202861&action=review


> Source/WebCore/ChangeLog:3
> +	   Animated GIFs don't repaint after TCADA un-suspends painting

TCADA wut?

> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:391
> +    if (m_webPage->windowIsVisible()) {
>	   m_webPage->corePage()->resumeScriptedAnimations();
> +	   m_webPage->corePage()->mainFrame()->view()->resumeAnimatingImages();

> +    }

Weird that this is in WK2 code. Are all of
m_webPage->corePage()->mainFrame()->view() always non-null?