[webkit-reviews] review granted: [Bug 116709] Improve loader/go-back-cached-main-resource.html test : [Attachment 202782] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 24 09:56:03 PDT 2013
Alexey Proskuryakov <ap at webkit.org> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 116709: Improve loader/go-back-cached-main-resource.html test
https://bugs.webkit.org/show_bug.cgi?id=116709
Attachment 202782: Patch
https://bugs.webkit.org/attachment.cgi?id=202782&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202782&action=review
Thank you!
> LayoutTests/loader/resources/first-page.html:11
> + if (!event.persisted) {
> + // Our opener will tell us to perform various loads.
Just for the information, WebKit style is to prefer early returns, not deep
indentation.
I don't think that it's worth changing for this test, it's an extremely minor
point.
More information about the webkit-reviews
mailing list