[webkit-reviews] review granted: [Bug 115135] WebProcess is crashing on http://achicu.github.io/css-presentation when direct pattern compositing is enabled : [Attachment 201294] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Noam Rosenthal <noam at webkit.org>'s
request for review:
Bug 115135: WebProcess is crashing on http://achicu.github.io/css-presentation
when direct pattern compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=115135

Attachment 201294: Patch
https://bugs.webkit.org/attachment.cgi?id=201294&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=201294&action=review


> Source/WebCore/rendering/RenderLayerBacking.cpp:1477
> +    CachedImage* cachedImage =
style->backgroundLayers()->image()->cachedImage();
> +    ASSERT(cachedImage);
> +
> +    RefPtr<Image> image = cachedImage->image();

This assertion seems unnecessary. Calling without null checking already
communicates that the pointer is expected not to be null and we are going to
get a clean crash anyway if it not.