[webkit-reviews] review granted: [Bug 116703] Typing in Safari's unified field causes unnecessary web content repaints. : [Attachment 202768] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 116703: Typing in Safari's unified field causes unnecessary web content
repaints.
https://bugs.webkit.org/show_bug.cgi?id=116703

Attachment 202768: Patch
https://bugs.webkit.org/attachment.cgi?id=202768&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202768&action=review


r=me. Looks like this is covered by the WebKit2.Find API test, so I assume this
test still passes after this change.

> Source/WebCore/page/Page.h:414
> +    unsigned findMatchesForText(const String&, FindOptions, unsigned
maxMatchCount, bool shouldHighlight, bool markMatches);

You could use enums for shouldHighlight and markMatches for some added
readability at call sites of this function.