[webkit-reviews] review denied: [Bug 116697] Prevent autofilled password field from getting cleared with a script : [Attachment 202754] Patch

[bugzilla-daemon at webkit.org]

Jessie Berlin <jberlin at webkit.org> has denied Sergey <sshapovalov at apple.com>'s
request for review:
Bug 116697: Prevent autofilled password field from getting cleared with a
script
https://bugs.webkit.org/show_bug.cgi?id=116697

Attachment 202754: Patch
https://bugs.webkit.org/attachment.cgi?id=202754&action=review

------- Additional Comments from Jessie Berlin <jberlin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202754&action=review


> Source/WebCore/html/HTMLInputElement.cpp:1031
> +	   return;

This is very clearly against specification.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-elemen
t-attributes.html#dom-input-value

"On setting, it must set the element's value to the new value"