[webkit-reviews] review denied: [Bug 116339] Add --sdk flag to jsDriver.pl to allow running in the iOS simulator : [Attachment 202635] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has denied David Farler
<dfarler at apple.com>'s request for review:
Bug 116339: Add --sdk flag to jsDriver.pl to allow running in the iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=116339

Attachment 202635: Patch
https://bugs.webkit.org/attachment.cgi?id=202635&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202635&action=review


r- to fix the --adopt-pid issue.

> Source/JavaScriptCore/ChangeLog:3
> +	   --sdk option to jsDriver.pl to run with iOS Simulator

What happened to "Add" in the title here?  :)

> Source/JavaScriptCore/tests/mozilla/jsDriver.pl:180
> +	       chomp($shell_command = `xcrun -sdk $opt_sim_sdk -find sim`) if
$opt_sim_sdk;
> +	       $shell_command .= " --adopt-pid ";

I think both of these need to be inside an if ($opt_sim_sdk) check since
--adopt-pid only makes sense when using the sim tool:

    if ($opt_sim_sdk) {
	chomp($shell_command = `xcrun -sdk $opt_sim_sdk -find sim`);
	$shell_command .= " --adopt-pid ";
    }