[webkit-reviews] review granted: [Bug 38756] new-run-webkit-tests: "win" port (Apple's Cygwin/Windows port) doesn't work : [Attachment 202647] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 23 13:51:14 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 38756: new-run-webkit-tests: "win" port (Apple's Cygwin/Windows port)
doesn't work
https://bugs.webkit.org/show_bug.cgi?id=38756

Attachment 202647: Patch
https://bugs.webkit.org/attachment.cgi?id=202647&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202647&action=review


> Tools/Scripts/webkitpy/port/win.py:107
> +    #
> +    # PROTECTED ROUTINES
> +    #
> +    # The routines below should only be called by routines in this class
> +    # or any of its subclasses.
> +    #

We don't normally add comments like this. Please remove them.


More information about the webkit-reviews mailing list