[webkit-reviews] review granted: [Bug 116451] Crash in convertMainResourceLoadToDownload when downloading file by option-return : [Attachment 202735] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 116451: Crash in convertMainResourceLoadToDownload when downloading file by
option-return
https://bugs.webkit.org/show_bug.cgi?id=116451

Attachment 202735: Patch
https://bugs.webkit.org/attachment.cgi?id=202735&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202735&action=review


r=me

> Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:181
> +    if (!mainResourceLoadIdentifier) {
> +	   NetworkProcess::shared().downloadManager().startDownload(downloadID,
request);
> +	   return;
> +    }

I think this could use a comment about what mainResourceLoadIdentifier=0 means.