[webkit-reviews] review granted: [Bug 116655] WebFrameProxy::didFailLoad clears frame title for no apparent reason : [Attachment 202657] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 23 10:55:00 PDT 2013


Alexey Proskuryakov <ap at webkit.org> has granted Santosh Mahto
<santosh.ma at samsung.com>'s request for review:
Bug 116655: WebFrameProxy::didFailLoad clears frame title for no apparent
reason
https://bugs.webkit.org/show_bug.cgi?id=116655

Attachment 202657: Patch
https://bugs.webkit.org/attachment.cgi?id=202657&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202657&action=review


But I still agree that the behavior is wrong.

> Source/WebKit2/ChangeLog:3
> +	   [WebFrameProxy::didFailLoad] title becomes empty even though
Page(and title) is

Please update the title in ChangeLog to match Bugzilla.

We use brackets in title for a very specific purpose (marking patches that are
of limited interest only).


More information about the webkit-reviews mailing list