[webkit-reviews] review canceled: [Bug 76048] [GTK] fast/text/font-kerning.html fails : [Attachment 202669] Patch

[bugzilla-daemon at webkit.org]

Denis Nomiyama (dnomi) <d.nomiyama at samsung.com> has canceled Denis Nomiyama
(dnomi) <d.nomiyama at samsung.com>'s request for review:
Bug 76048: [GTK] fast/text/font-kerning.html fails
https://bugs.webkit.org/show_bug.cgi?id=76048

Attachment 202669: Patch
https://bugs.webkit.org/attachment.cgi?id=202669&action=review

------- Additional Comments from Denis Nomiyama (dnomi)
<d.nomiyama at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202669&action=review


>> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp:502
>> +	    } else
> 
> Hrm. A more likely location for this change is
HarfBuzzShaper::setFontFeatures where the rest of the feature are set, no?
Aren't you also adding 'kern' to the feature list here instead of removing it?

Good point about setFontFeatures(). The idea is to add 'kern' as 0 (disabled)
to the feature list in case of NoneKerning. I will also include a case for
NormalKerning.