[webkit-reviews] review denied: [Bug 116674] [BlackBerry] Improve input form control handling. : [Attachment 202711] Validation patch.

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has denied Mike Fenton
<mifenton at blackberry.com>'s request for review:
Bug 116674: [BlackBerry] Improve input form control handling.
https://bugs.webkit.org/show_bug.cgi?id=116674

Attachment 202711: Validation patch.
https://bugs.webkit.org/attachment.cgi?id=202711&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202711&action=review


> Source/WebKit/blackberry/ChangeLog:3
> +	   [BlackBerry] Improve input form control handling.

We should do one patch per bug. I suggest we rename this to something related
to form validation, and move the other patch elsewhere.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1022
> +	   formElement->submit();

Makes sense to me otherwise, seems it just moves code around to check validity
before doing submit(). So please rename the title to land it!