[webkit-reviews] review denied: [Bug 116657] [EFL][WK2] Use WK2 C API in ewk_view_pagination_mode_set|get : [Attachment 202659] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 23 04:06:19 PDT 2013


Christophe Dumez <dchris at gmail.com> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 116657: [EFL][WK2] Use WK2 C API in ewk_view_pagination_mode_set|get
https://bugs.webkit.org/show_bug.cgi?id=116657

Attachment 202659: Patch
https://bugs.webkit.org/attachment.cgi?id=202659&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202659&action=review


> Source/WebKit2/ChangeLog:8
> +	   WKPageGet|SetPaginationMode APIs appear on WK2 C APIs. So, we need
to use them for

"appear on" -> "is present in"

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:511
> +    WKPageSetPaginationMode(impl->wkPage(),
static_cast<WebCore::Pagination::Mode>(mode));

This should really be casted to a WKPaginationMode, not a
WebCore::Pagination::Mode. The COMPILE_ASSERT_MATCHING_ENUM() above need to be
updated or we need a static inline function to convert one enum into another.
Can you check if we can get rid of the "using namespace WebCore;" and maybe a
few WebCore includes?


More information about the webkit-reviews mailing list