[webkit-reviews] review denied: [Bug 116312] [WK2][WTR]Adding Layout test framework for MHTML page content : [Attachment 202253] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Santosh Mahto
<santoshbit2007 at gmail.com>'s request for review:
Bug 116312: [WK2][WTR]Adding Layout test framework  for  MHTML page content
https://bugs.webkit.org/show_bug.cgi?id=116312

Attachment 202253: Patch
https://bugs.webkit.org/attachment.cgi?id=202253&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202253&action=review


This is a start, but that is not the proper way to test code with an API on the
UIProcess.

Instead, what should happen is the InjectedBundle sends a message to the
UIProcess asking for the data. The UIProcess uses the public API
(WKPageGetContentsAsMHTMLData) and return the value to the injected bundle
asynchronously.

On a more generic standpoint. Why wouldn't the test always dump 2 expected
results? One binary, one text?

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:325
> +    bool m_useBinaryEncoding;

Instead of this, I would just have two WhatToDump:
    MHTMLArchive && MHTMLBinaryArchive