[webkit-reviews] review granted: [Bug 116490] Don't snapshot plugins that can't be snapshotted : [Attachment 202629] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 116490: Don't snapshot plugins that can't be snapshotted
https://bugs.webkit.org/show_bug.cgi?id=116490

Attachment 202629: Patch
https://bugs.webkit.org/attachment.cgi?id=202629&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202629&action=review


> Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp:236
> +    if (m_waitingOnAsynchronousInitialization)
> +	   return false;

Hmmmmmm.

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:579
> +	   if (m_plugin->pluginLayer()) {
> +	       if (frame()) {

All-in-one-if

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1641
> +    if (!m_plugin->supportsSnapshotting() &&
m_pluginElement->isPlugInImageElement()) {

I think the first one is significantly more expensive to compute (needs IPC),
should you swap these? (answer: it doesn't matter because this is not hot code
at all).