[webkit-reviews] review granted: [Bug 116639] Fix assertion in the getComputedStyle-background-shorthand.html test : [Attachment 202627] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 22 15:17:51 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 116639: Fix assertion in the getComputedStyle-background-shorthand.html
test
https://bugs.webkit.org/show_bug.cgi?id=116639

Attachment 202627: Patch
https://bugs.webkit.org/attachment.cgi?id=202627&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202627&action=review


> Source/WebCore/rendering/RenderObject.cpp:2527
> +    if (!isText()) {

I wish we had a way to assert that this is the only case we have to worry
about.


More information about the webkit-reviews mailing list