[webkit-reviews] review granted: [Bug 116628] [WK2] Crashes in NetworkProcess due to incorrect private browsing session tracking : [Attachment 202615] proposed fix

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 116628: [WK2] Crashes in NetworkProcess due to incorrect private browsing
session tracking
https://bugs.webkit.org/show_bug.cgi?id=116628

Attachment 202615: proposed fix
https://bugs.webkit.org/attachment.cgi?id=202615&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202615&action=review


Seems fine.  Please clean up some of the comments.

> Source/WebKit2/ChangeLog:19
> +	   means that it will be harder to spot logic errors with using a wrong
session.

when* using a wrong session?

> Source/WebKit2/UIProcess/WebContext.cpp:378
> +    // If private browsing if enabled through preferences but not
re-enabled, NetworkProcess will crash.

This sentence has grammar errors, and I don't understand what it's trying to
say.