[webkit-reviews] review granted: [Bug 116339] Add --sdk flag to jsDriver.pl to allow running in the iOS simulator : [Attachment 202577] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 22 12:33:52 PDT 2013


Joseph Pecoraro <joepeck at webkit.org> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 116339: Add --sdk flag to jsDriver.pl to allow running in the iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=116339

Attachment 202577: Patch
https://bugs.webkit.org/attachment.cgi?id=202577&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202577&action=review


r=me

> Source/JavaScriptCore/tests/mozilla/jsDriver.pl:68
> +my $opt_sim_sdk = '';

I think our style is double quoted strings in perl. Here and else where. I'm
not sure how strict that is, I don't mind seeing either.


More information about the webkit-reviews mailing list