[webkit-reviews] review granted: [Bug 116581] [css] Update ETextDecorations enum to TextDecorations (incl. enumeration values) : [Attachment 202486] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 22 10:50:25 PDT 2013
Andreas Kling <akling at apple.com> has granted Bruno Abinader
<bruno.abinader at basyskom.com>'s request for review:
Bug 116581: [css] Update ETextDecorations enum to TextDecorations (incl.
enumeration values)
https://bugs.webkit.org/show_bug.cgi?id=116581
Attachment 202486: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=202486&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202486&action=review
r=me. This looks way better!
> Source/WebCore/rendering/style/RenderStyleConstants.h:344
> + TextDecorationNone = 0x0 , TextDecorationUnderline = 0x1,
TextDecorationOverline = 0x2, TextDecorationLineThrough= 0x4,
TextDecorationBlink = 0x8
Missing space after TextDecorationLineThrough.
More information about the webkit-reviews
mailing list