[webkit-reviews] review granted: [Bug 116605] [Mac] Captions menu isn't internationalized, doesn't use rtl layout for rtl languages : [Attachment 202515] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 22 08:26:30 PDT 2013


Eric Carlson <eric.carlson at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 116605: [Mac] Captions menu isn't internationalized, doesn't use rtl layout
for rtl languages
https://bugs.webkit.org/show_bug.cgi?id=116605

Attachment 202515: Patch
https://bugs.webkit.org/attachment.cgi?id=202515&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202515&action=review


> Source/WebCore/ChangeLog:32
> +	   Makr the checkmarks a ::before pseudo-class rather than a
background-image such that

Nit: Makr -> Make

> Source/WebCore/ChangeLog:33
> +	   we may control is positioning using the internationlization-friendly
"-webkit-margin-start"

Nit: is -> its


More information about the webkit-reviews mailing list